[GitHub] [pinot] 61yao commented on a diff in pull request #9969: [multistage] [bugfix] Throw error when GrpcMailbox receiving buffer is full

[GitBox <gi...@apache.org>]

61yao commented on code in PR #9969:
URL: https://github.com/apache/pinot/pull/9969#discussion_r1047651175


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentStreamObserver.java:
##########
@@ -93,7 +105,19 @@ public void onNext(Mailbox.MailboxContent mailboxContent) {
 
     if (!mailboxContent.getMetadataMap().containsKey(ChannelUtils.MAILBOX_METADATA_BEGIN_OF_STREAM_KEY)) {
       // when the receiving end receives a message put it in the mailbox queue.
-      _receivingBuffer.offer(mailboxContent);
+      // TODO: pass a timeout to _receivingBuffer.
+      if (!_receivingBuffer.offer(mailboxContent)) {

Review Comment:
   yes. Eventually, we should utilize GRPC streaming buffer for this.  We need to put more thoughts into that. As said in the PR description , this PR doesn't intent to fix the issue. It serves as  a quick bandaid to throw error instead of silently returning incorrect result. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org