You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/04/20 11:58:34 UTC

[kudu-CR] [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18432


Change subject: [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan
......................................................................

[unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18432/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18432

to look at the new patch set (#2).

Change subject: [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan
......................................................................

[unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18432/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18432 )

Change subject: [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan
......................................................................


Patch Set 3: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sun, 24 Apr 2022 06:47:35 +0000
Gerrit-HasComments: No

[kudu-CR] [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18432 )

Change subject: [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan
......................................................................

[unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

tsan is slow, and case ToolTest.TestRebuildTserverByLocalReplicaCopy
maybe fail.

Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Reviewed-on: http://gerrit.cloudera.org:8080/18432
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18432

to look at the new patch set (#3).

Change subject: [unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan
......................................................................

[unit test] make ToolTest.TestRebuildTserverByLocalReplicaCopy skip tsan

tsan is slow, and case ToolTest.TestRebuildTserverByLocalReplicaCopy
maybe fail.

Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18432/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4da90d728c9fbd34c9c3c4de3fe7089c07e25b42
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)