[GitHub] [calcite] jacques-n commented on a change in pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

[GitBox <gi...@apache.org>]

jacques-n commented on a change in pull request #2622:
URL: https://github.com/apache/calcite/pull/2622#discussion_r770123359



##########
File path: elasticsearch/build.gradle.kts
##########
@@ -20,6 +20,12 @@ plugins {
     id("com.github.vlsi.gradle-extensions")
 }
 
+repositories {
+    maven {
+        setUrl("https://maven.codelibs.org/")

Review comment:
       Why do we need to add a repository? It seems like we already source some stuff from org.codelibs, is this new things now available in the existing repositories?

##########
File path: elasticsearch/build.gradle.kts
##########
@@ -40,7 +46,7 @@ dependencies {
     // https://github.com/elastic/elasticsearch/issues/49218

Review comment:
       Is this issue not fixed in elastic 7.15.2? It looks like it was fixed a couple years ago...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org