[GitHub] [incubator-nemo] DifferentSC commented on a change in pull request #236: [NEMO-397] Separation of JVM heap region and off-heap memory region

[GitBox <gi...@apache.org>]

DifferentSC commented on a change in pull request #236: [NEMO-397] Separation of JVM heap region and off-heap memory region
URL: https://github.com/apache/incubator-nemo/pull/236#discussion_r317034451
 
 

 ##########
 File path: conf/src/main/java/org/apache/nemo/conf/JobConf.java
 ##########
 @@ -299,12 +299,19 @@
   public final class PartitionTransportClientNumThreads implements Name<Integer> {
   }
 
+  /**
+   * Maximum off-heap memory ratio to the total memory in the executor.
+   */
+  @NamedParameter(doc = "The ratio of total memory for maximum off-heap memory use",
 
 Review comment:
   The maximum ratio of off-heap memory size to the total memory size.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services