You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/26 18:57:39 UTC
[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2
of changes for SQL Compatible Null Handling
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205567545
##########
File path: processing/src/main/java/io/druid/query/aggregation/AggregatorUtil.java
##########
@@ -168,7 +168,7 @@ public static BaseFloatColumnValueSelector makeColumnValueSelectorWithFloatDefau
public float getFloat()
{
final ExprEval exprEval = baseSelector.getObject();
- return exprEval.isNull() ? nullValue : (float) exprEval.asDouble();
+ return exprEval.isNumericNull() ? nullValue : (float) exprEval.asDouble();
Review comment:
can you elaborate on when it can be null,
I think it will be ExprEval.of(null) instead of null itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org