You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:27:28 UTC
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20226: refactor: decouple DataTableControl
zhaoyongjie commented on code in PR #20226:
URL: https://github.com/apache/superset/pull/20226#discussion_r885520268
##########
superset-frontend/src/explore/components/DataTableControl/index.tsx:
##########
@@ -130,8 +126,8 @@ export const RowCount = ({
}) => <RowCountLabel rowcount={data?.length ?? 0} loading={loading} />;
enum FormatPickerValue {
- Formatted,
- Original,
+ Formatted = 'formatted',
Review Comment:
The string enum is more readable in the debugger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org