You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "xuang7 (via GitHub)" <gi...@apache.org> on 2026/06/02 07:17:12 UTC
[PR] feat: add card view to the private dataset listing [texera]
xuang7 opened a new pull request, #5313:
URL: https://github.com/apache/texera/pull/5313
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
This PR adds the card view to the user's private dataset listing (/dashboard/user/dataset), with a toggle to switch between the existing list view and the card view. It is the follow-up to the public dataset card view and reuses the same framework.
Changes:
- List/card toggle on the personal dataset listing. A bars/grid toggle next to the filters switches SearchResultsComponent between list and card mode. The selected mode persists per-user via localStorage (key texera.user.dataset.viewMode).
- Reused DatasetCardItemComponent through the existing cardTemplate projection on SearchResultsComponent, so the personal listing and the public hub share one card component.
- Added a management actions menu (⋮) to the dataset card, mirroring what the list view already exposes for datasets: Share, Download, and Delete (Delete is disabled for non-owners and asks for confirmation). The menu is gated behind a new `showActions` input, so it renders only on the private listing and not on the public hub.
- Added showActions input and deleted/refresh outputs to DatasetCardItemComponent to wire the actions back to UserDatasetComponent.
Demo:
<img width="1479" height="518" alt="card-view" src="https://github.com/user-attachments/assets/05097ad3-22d2-4400-836e-17c36b7461bd" />
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234`
or `Closes #1234`. If it is only related, simply mention the issue number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
Closes #5312
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the PR
is tested with existing test cases. Make sure to include/update test cases that
check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how
you tested step by step, ideally copy and paste-able, so that other reviewers can
test and check, and descendants can verify in the future. If tests were not added,
please describe why they were not added and/or why it was difficult to add.
-->
Added test cases and manually tested.
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Opus 4.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add card view to the private dataset listing [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5313:
URL: https://github.com/apache/texera/pull/5313#issuecomment-4599731840
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5313?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.14925%` with `20 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 50.35%. Comparing base ([`223a27b`](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7b37407`](https://app.codecov.io/gh/apache/texera/commit/7b37407b53eda155ebdfb408a3cc3cd1c291c393?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/5313?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...nent/user/user-dataset/user-dataset.component.html](https://app.codecov.io/gh/apache/texera/pull/5313?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fuser%2Fuser-dataset%2Fuser-dataset.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L3VzZXIvdXNlci1kYXRhc2V0L3VzZXItZGF0YXNldC5jb21wb25lbnQuaHRtbA==) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/5313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...r/dataset-card-item/dataset-card-item.component.ts](https://app.codecov.io/gh/apache/texera/pull/5313?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fuser%2Fdataset-card-item%2Fdataset-card-item.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L3VzZXIvZGF0YXNldC1jYXJkLWl0ZW0vZGF0YXNldC1jYXJkLWl0ZW0uY29tcG9uZW50LnRz) | 88.23% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/5313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ponent/user/user-dataset/user-dataset.component.ts](https://app.codecov.io/gh/apache/texera/pull/5313?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fuser%2Fuser-dataset%2Fuser-dataset.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L3VzZXIvdXNlci1kYXRhc2V0L3VzZXItZGF0YXNldC5jb21wb25lbnQudHM=) | 75.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/5313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5313 +/- ##
============================================
+ Coverage 50.29% 50.35% +0.05%
Complexity 2417 2417
============================================
Files 1054 1054
Lines 40905 40966 +61
Branches 4378 4383 +5
============================================
+ Hits 20575 20627 +52
- Misses 19100 19107 +7
- Partials 1230 1232 +2
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.89% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.99% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.38% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.68% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.42% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.47% <70.14%> (+0.15%)` | :arrow_up: | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.80% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.80% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.39% <ø> (ø)` | | Carriedforward from [223a27b](https://app.codecov.io/gh/apache/texera/commit/223a27b2929cff6b164030eea385fe143ba51791?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5313?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add card view to the private dataset listing [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #5313:
URL: https://github.com/apache/texera/pull/5313#issuecomment-4796935185
Closing this PR because #5947 will replace this implementation with the generic CardItemComponent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add card view to the private dataset listing [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 closed pull request #5313: feat: add card view to the private dataset listing
URL: https://github.com/apache/texera/pull/5313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org