You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/08/05 06:10:01 UTC
[GitHub] [thrift] frankiechang123 opened a new pull request #2432: THRIFT-5449: Use poll instead of select in Python TNonblockingServer …
frankiechang123 opened a new pull request #2432:
URL: https://github.com/apache/thrift/pull/2432
Use poll instead of select if possible
<!-- Explain the changes in the pull request below: -->
Currently, Python TNonblockingServer uses `select.select` to monitor the IO of all existing connections. The value of file descriptors monitored by `select()` is limited to be lower than FD_SETSIZE (1024). Any file descriptor higher than 1024 will trigger the `fd out of range` error in `select.select`
Switching to `select.poll` can solve this problem. However, as noted in the [official documentation](https://docs.python.org/3/library/select.html#select.poll), `select.poll` is not supported in all operating systems. We should also check whether the current system has `poll` in the select module, and use `poll` if it's available.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] frankiechang123 commented on pull request #2432: THRIFT-5449: Use poll instead of select in Python TNonblockingServer if available
Posted by GitBox <gi...@apache.org>.
frankiechang123 commented on pull request #2432:
URL: https://github.com/apache/thrift/pull/2432#issuecomment-901641120
I think the Travis CI is falling for unrelated reasons. Will this PR be reviewed soon? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] frankiechang123 edited a comment on pull request #2432: THRIFT-5449: Use poll instead of select in Python TNonblockingServer if available
Posted by GitBox <gi...@apache.org>.
frankiechang123 edited a comment on pull request #2432:
URL: https://github.com/apache/thrift/pull/2432#issuecomment-901641120
I think the Travis CI is failing for unrelated reasons. Will this PR be reviewed soon? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org