[GitHub] [accumulo-proxy] DomGarguilo opened a new issue, #71: SimpleProxyBase.testCompactionSelector should not be passing

["DomGarguilo (via GitHub)" <gi...@apache.org>]

DomGarguilo opened a new issue, #71:
URL: https://github.com/apache/accumulo-proxy/issues/71

   In 65fd1bbf2494b4ae0071ca99ce8740943a6df479 I pushed some changes to wrap the `Wait.waitFor()` blocks in the tests in `assertTrue()`. The `Wait.waitFor()` method will not fail on its own and simply returns a boolean which **was** being ignored in all of the tests, and **still is** being ignored in testCompactionSelector.
   
   The condition in the test,
   ```java
   Wait.waitFor(() -> countFiles(tableName) == (expectedFileCount / 2));
   ```
   checks to make sure that half of the files were compacted in accordance with the SelectHalfSelector being used in the test. After correctly checking the return value for this condition, it is evident that the selector is not working as intended and the number of files does not change after compaction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo-proxy] DomGarguilo closed issue #71: SimpleProxyBase.testCompactionSelector should not be passing

["DomGarguilo (via GitHub)" <gi...@apache.org>]

DomGarguilo closed issue #71: SimpleProxyBase.testCompactionSelector should not be passing
URL: https://github.com/apache/accumulo-proxy/issues/71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org