You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Johan Corveleyn <jc...@gmail.com> on 2011/06/02 23:18:41 UTC

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

On Thu, Jun 2, 2011 at 2:59 PM,  <st...@apache.org> wrote:
> Author: stefan2
> Date: Thu Jun  2 12:59:59 2011
> New Revision: 1130528
>
> URL: http://svn.apache.org/viewvc?rev=1130528&view=rev
> Log:
> Replace calls to svn_string_create_from_buf with the much cheaper
> svn_string_create_from_buf. This is possible in all places where
  ^^^^^^^^^^^^^^^^^^^^^^^

should be 'svn_string_from_buf'. I know the function has since been
renamed, but in the interest of consistency of log messages with
commit content ...

-- 
Johan

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

Posted by Johan Corveleyn <jc...@gmail.com>.
On Fri, Jun 3, 2011 at 10:56 AM, Julian Foad <ju...@wandisco.com> wrote:
> On Thu, 2011-06-02 at 23:18 +0200, Johan Corveleyn wrote:
>> On Thu, Jun 2, 2011 at 2:59 PM,  <st...@apache.org> wrote:
>> > Author: stefan2
>> > Date: Thu Jun  2 12:59:59 2011
>> > New Revision: 1130528
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1130528&view=rev
>> > Log:
>> > Replace calls to svn_string_create_from_buf with the much cheaper
>> > svn_string_create_from_buf. This is possible in all places where
>>   ^^^^^^^^^^^^^^^^^^^^^^^
>>
>> should be 'svn_string_from_buf'. I know the function has since been
>> renamed, but in the interest of consistency of log messages with
>> commit content ...
>
> Should be 'svn_string_from_stringbuf' in fact.

Doh!

> Fixed.

Thanks :)

-- 
Johan

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

Posted by Julian Foad <ju...@wandisco.com>.
On Thu, 2011-06-02 at 23:18 +0200, Johan Corveleyn wrote:
> On Thu, Jun 2, 2011 at 2:59 PM,  <st...@apache.org> wrote:
> > Author: stefan2
> > Date: Thu Jun  2 12:59:59 2011
> > New Revision: 1130528
> >
> > URL: http://svn.apache.org/viewvc?rev=1130528&view=rev
> > Log:
> > Replace calls to svn_string_create_from_buf with the much cheaper
> > svn_string_create_from_buf. This is possible in all places where
>   ^^^^^^^^^^^^^^^^^^^^^^^
> 
> should be 'svn_string_from_buf'. I know the function has since been
> renamed, but in the interest of consistency of log messages with
> commit content ...

Should be 'svn_string_from_stringbuf' in fact.

Fixed.

- Julian