You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Vamshi Vijay Nakkirtha (JIRA)" <ji...@apache.org> on 2019/05/18 08:33:00 UTC
[jira] [Commented] (LUCENE-8804) FieldType attribute map should not
be modifiable after freeze
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843119#comment-16843119 ]
Vamshi Vijay Nakkirtha commented on LUCENE-8804:
------------------------------------------------
Attached patch.
Added unit tests and verified tests pass
> FieldType attribute map should not be modifiable after freeze
> -------------------------------------------------------------
>
> Key: LUCENE-8804
> URL: https://issues.apache.org/jira/browse/LUCENE-8804
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Affects Versions: 8.0
> Reporter: Vamshi Vijay Nakkirtha
> Priority: Minor
> Labels: features, patch
> Attachments: LUCENE-8804.patch
>
>
> Today FieldType attribute map can be modifiable even after freeze. For all other properties of FieldType, we do "checkIfFrozen()" before making the update to the property but for attribute map, we does not seem to make such check.
>
> [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.0.0/lucene/core/src/java/org/apache/lucene/document/FieldType.java#L363]
> we may need to add check at the beginning of the function similar to other properties setters.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org