[GitHub] uce commented on a change in pull request #7745: [FLINK-11632] Add new config option for TaskManager automatic address binding

[GitBox <gi...@apache.org>]

uce commented on a change in pull request #7745: [FLINK-11632] Add new config option for TaskManager automatic address binding
URL: https://github.com/apache/flink/pull/7745#discussion_r258858149
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
 ##########
 @@ -409,13 +409,30 @@ public static RpcService createRpcService(
 		if (taskManagerHostname != null) {
 			LOG.info("Using configured hostname/address for TaskManager: {}.", taskManagerHostname);
 		} else {
-			Time lookupTimeout = Time.milliseconds(AkkaUtils.getLookupTimeout(configuration).toMillis());
-
-			InetAddress taskManagerAddress = LeaderRetrievalUtils.findConnectingAddress(
-				haServices.getResourceManagerLeaderRetriever(),
-				lookupTimeout);
-
-			taskManagerHostname = taskManagerAddress.getHostName();
+			InetAddress taskManagerAddress;
 
 Review comment:
   @tillrohrmann I would actually prefer to remove `auto-detect-hostname` and stick to the proposal above (just `ip` or `hostname`). Having this many options complicates things in my opinion.
   
   @1u0 As another note, why don't we do:
   ```java
   case "ip":
     taskManagerHostName = InetAddress.getByName(taskManagerAddress.getHostName());
     break;
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services