You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/10/03 14:10:10 UTC

Review Request 52484: LENS-1343: expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52484/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1343
    https://issues.apache.org/jira/browse/LENS-1343


Repository: lens


Description
-------


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6e52d32f5b4e2e4a0579e9d9b010f361e8aad24d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 861d4f7b5544d28e09af398c50223d04b13ac191 
  lens-cube/src/test/resources/hive-site.xml d21e61c2bcd68adbd579b8bf6dffbeec9fa24fd7 
  lens-driver-hive/src/test/resources/hive-site.xml 48ec90fe1db69fa133a2410795d253495ea25b2c 

Diff: https://reviews.apache.org/r/52484/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 52484: LENS-1343: expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52484/#review151308
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 3, 2016, 2:14 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52484/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 2:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1343
>     https://issues.apache.org/jira/browse/LENS-1343
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6e52d32f5b4e2e4a0579e9d9b010f361e8aad24d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 861d4f7b5544d28e09af398c50223d04b13ac191 
>   lens-cube/src/test/resources/hive-site.xml d21e61c2bcd68adbd579b8bf6dffbeec9fa24fd7 
> 
> Diff: https://reviews.apache.org/r/52484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 52484: LENS-1343: expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52484/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 2:42 p.m.)


Review request for lens.


Bugs: LENS-1343
    https://issues.apache.org/jira/browse/LENS-1343


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6e52d32f5b4e2e4a0579e9d9b010f361e8aad24d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 861d4f7b5544d28e09af398c50223d04b13ac191 
  lens-cube/src/test/resources/hive-site.xml d21e61c2bcd68adbd579b8bf6dffbeec9fa24fd7 

Diff: https://reviews.apache.org/r/52484/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 52484: LENS-1343: expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52484/
-----------------------------------------------------------

(Updated Oct. 3, 2016, 7:44 p.m.)


Review request for lens.


Bugs: LENS-1343
    https://issues.apache.org/jira/browse/LENS-1343


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6e52d32f5b4e2e4a0579e9d9b010f361e8aad24d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 861d4f7b5544d28e09af398c50223d04b13ac191 
  lens-cube/src/test/resources/hive-site.xml d21e61c2bcd68adbd579b8bf6dffbeec9fa24fd7 

Diff: https://reviews.apache.org/r/52484/diff/


Testing
-------


Thanks,

Rajat Khandelwal