[GitHub] [spark] kiszk commented on issue #27860: [SPARK-31101][SQL][BUILD] Upgrade Janino to 3.1.2

[GitBox <gi...@apache.org>]

kiszk commented on issue #27860: [SPARK-31101][SQL][BUILD] Upgrade Janino to 3.1.2
URL: https://github.com/apache/spark/pull/27860#issuecomment-601365859
 
 
   From the technical perspective, I absolutely agree to merge this into Spark 3.0.
   
   But, I have the mixed feeling in my mind. I agree with [this comment](https://github.com/apache/spark/pull/27872#issuecomment-601091320).   
   It is a big change to upgrade the major version of Janino. Thus, I do not feel strong to merge this into 3.0 from the release management perspective. On the other hand, it is not good to stick the depreciated Janino 3.0 at Spark 3.0. From the maintenance perspective, I agree to merge this into Spark 3.0.
   
   After a long thinking, I agree to merge this into Spark 3.0 if this PR does not cause performance regression. The Spark community appreciates it if Databricks team can measure the performance and run additional regression tests.  cc @gatorsmile 
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org