You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/10/03 12:43:03 UTC
[GitHub] [incubator-iceberg] TGooch44 commented on a change in pull request
#407: [python] Parquet read path
TGooch44 commented on a change in pull request #407: [python] Parquet read path
URL: https://github.com/apache/incubator-iceberg/pull/407#discussion_r331016952
##########
File path: python/iceberg/api/file_format.py
##########
@@ -20,16 +20,18 @@
@unique
class FileFormat(Enum):
-
- ORC = "orc"
- PARQUET = "parquet"
- AVRO = "avro"
+ ORC = "orc", True
Review comment:
All right fixed the test and lint errors. I agree that it's better to be explicit about the enum attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org