You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/04/12 16:50:21 UTC
Re: Review Request: Fixed a memory leak bug in stout/result.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9512/
-----------------------------------------------------------
(Updated April 12, 2013, 2:50 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Rebase on the current trunk.
Description
-------
The old object needs to be deleted in the assignment operator overload function.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/result.hpp 3326da0
Diff: https://reviews.apache.org/r/9512/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request: Fixed a memory leak bug in stout/result.hpp.
Posted by Jie Yu <yu...@gmail.com>.
Done.
On Fri, Apr 12, 2013 at 1:09 PM, Ben Mahler <be...@gmail.com>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9512/#review19082
> -----------------------------------------------------------
>
>
> Hey Jie, I just committed this change, can you mark it as submitted?
>
> - Ben Mahler
>
>
> On April 12, 2013, 2:50 p.m., Jie Yu wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9512/
> > -----------------------------------------------------------
> >
> > (Updated April 12, 2013, 2:50 p.m.)
> >
> >
> > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> >
> >
> > Description
> > -------
> >
> > The old object needs to be deleted in the assignment operator overload
> function.
> >
> >
> > Diffs
> > -----
> >
> > third_party/libprocess/third_party/stout/include/stout/result.hpp
> 3326da0
> >
> > Diff: https://reviews.apache.org/r/9512/diff/
> >
> >
> > Testing
> > -------
> >
> > make check
> >
> >
> > Thanks,
> >
> > Jie Yu
> >
> >
>
>
Re: Review Request: Fixed a memory leak bug in stout/result.hpp.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9512/#review19082
-----------------------------------------------------------
Hey Jie, I just committed this change, can you mark it as submitted?
- Ben Mahler
On April 12, 2013, 2:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9512/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 2:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> The old object needs to be deleted in the assignment operator overload function.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/result.hpp 3326da0
>
> Diff: https://reviews.apache.org/r/9512/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>