You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/12 14:19:36 UTC

[GitHub] [shardingsphere] yx9o opened a new pull request, #20941: Migrate global rule (SQLTranslatorRule) to shardingsphere-sql-translator-distsql module.

yx9o opened a new pull request, #20941:
URL: https://github.com/apache/shardingsphere/pull/20941

   For #17423, migrate global rule (SQLTranslatorRule) to shardingsphere-sql-translator-distsql module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang merged pull request #20941: Migrate global rule (SQLTranslatorRule) to shardingsphere-sql-translator-distsql module.

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #20941:
URL: https://github.com/apache/shardingsphere/pull/20941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #20941: Migrate global rule (SQLTranslatorRule) to shardingsphere-sql-translator-distsql module.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20941:
URL: https://github.com/apache/shardingsphere/pull/20941#issuecomment-1246196157

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20941](https://codecov.io/gh/apache/shardingsphere/pull/20941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75b9ee2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5849b5aabbb6fed04b7a3c1d4d9d8b0bbb5a615f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5849b5a) will **decrease** coverage by `0.02%`.
   > The diff coverage is `39.13%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #20941      +/-   ##
   ============================================
   - Coverage     61.80%   61.78%   -0.03%     
   + Complexity     2464     2463       -1     
   ============================================
     Files          4032     4035       +3     
     Lines         55441    55448       +7     
     Branches       9398     9399       +1     
   ============================================
   - Hits          34267    34260       -7     
   - Misses        18305    18318      +13     
   - Partials       2869     2870       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9rZXJuZWwvS2VybmVsRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...per/YamlSQLTranslatorRuleConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IveWFtbC9zd2FwcGVyL1lhbWxTUUxUcmFuc2xhdG9yUnVsZUNvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...istsql/parser/core/SQLTranslatorDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc3FsLXRyYW5zbGF0b3ItZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IvZGlzdHNxbC9wYXJzZXIvY29yZS9TUUxUcmFuc2xhdG9yRGlzdFNRTFBhcnNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ser/core/SQLTranslatorDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc3FsLXRyYW5zbGF0b3ItZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IvZGlzdHNxbC9wYXJzZXIvY29yZS9TUUxUcmFuc2xhdG9yRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ade/SQLTranslatorDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc3FsLXRyYW5zbGF0b3ItZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IvZGlzdHNxbC9wYXJzZXIvZmFjYWRlL1NRTFRyYW5zbGF0b3JEaXN0U1FMU3RhdGVtZW50UGFyc2VyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `75.60% <ø> (-0.59%)` | :arrow_down: |
   | [.../distsql/ral/impl/QueryableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9RdWVyeWFibGVSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `96.55% <ø> (ø)` | |
   | [...ueryable/ShowSQLTranslatorRuleStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9xdWVyeWFibGUvU2hvd1NRTFRyYW5zbGF0b3JSdWxlU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `40.00% <ø> (ø)` | |
   | [...sql/handler/query/SQLParserRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1wYXJzZXItZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wYXJzZXIvZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1NRTFBhcnNlclJ1bGVRdWVyeVJlc3VsdFNldC5qYXZh) | `50.00% <33.33%> (-10.00%)` | :arrow_down: |
   | [...stsql/handler/SQLTranslatorRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc3FsLXRyYW5zbGF0b3ItZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWx0cmFuc2xhdG9yL2Rpc3RzcWwvaGFuZGxlci9TUUxUcmFuc2xhdG9yUnVsZVF1ZXJ5UmVzdWx0U2V0LmphdmE=) | `55.55% <55.55%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/20941/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org