[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8490: [Bug-8110][WorkerServer] kill all running task before worker stop

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #8490:
URL: https://github.com/apache/dolphinscheduler/pull/8490#discussion_r811820787



##########
File path: dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/task/TaskExecutionContextCacheManager.java
##########
@@ -66,4 +67,8 @@ public static boolean updateTaskExecutionContext(TaskRequest request) {
         taskRequestContextCache.computeIfPresent(request.getTaskInstanceId(), (k, v) -> request);
         return taskRequestContextCache.containsKey(request.getTaskInstanceId());
     }
+
+    public static Collection<TaskRequest> getAllTaskRequestList() {

Review comment:
       It is just a easy method without handle logic. So I think we can add comment but it is useless.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org