[jira] [Comment Edited] (COLLECTIONS-737) The test FluentIterableTest.size should be splitted

["Chen Guoping (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984078#comment-16984078 ] 

Chen Guoping edited comment on COLLECTIONS-737 at 11/28/19 2:11 AM:
--------------------------------------------------------------------

Considering the efficiency,I think it is faster to add a judgment which will return 0 as empty immediately if iterable is null, and the overall implementation is indeed no problem.

Best wishes and regards


was (Author: guoping):
From a performance point of view, it is faster to add a judgment to return 0 as empty, and the overall implementation is indeed no problem.

Best wishes and regards

> The test FluentIterableTest.size should be splitted
> ---------------------------------------------------
>
>                 Key: COLLECTIONS-737
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-737
>             Project: Commons Collections
>          Issue Type: Test
>          Components: Collection
>            Reporter: Pengyu Nie
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The first part of FluentIterableTest.size is not testing function
> FluentIterable.size (see code copied below). Actually,
> FluentIterable.size will not be invoked at all, because
> FluentIterable.of(null) will throw an NPE before that. This part
> should be extracted as a separate unit test like
> FluentIterableTest.ofNull.
> {code:java}
> try {
>     FluentIterable.of((Iterable<?>) null).size();
>     fail("expecting NullPointerException");
> } catch (final NullPointerException npe) {
>     // expected
> }{code}
> I'll create a pull request for this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)