[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3754: MINOR: Improvements to `scalar_subquery_to_join` error handling

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3754:
URL: https://github.com/apache/arrow-datafusion/pull/3754#discussion_r990631919


##########
datafusion/optimizer/src/scalar_subquery_to_join.rs:
##########
@@ -21,7 +21,7 @@ use crate::utils::{
 };
 use crate::{utils, OptimizerConfig, OptimizerRule};
 use datafusion_common::{context, plan_err, Column, Result};
-use datafusion_expr::logical_plan::{Aggregate, Filter, JoinType, Projection, Subquery};
+use datafusion_expr::logical_plan::{Filter, JoinType, Limit, Subquery};
 use datafusion_expr::{combine_filters, Expr, LogicalPlan, LogicalPlanBuilder, Operator};

Review Comment:
   > The idea here is that if the particular subquery isn't supported by the physical operators, it will error out at that time?
   
   Yes, exactly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org