You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2011/02/28 23:18:36 UTC
[jira] Created: (HIVE-2012) Improve parser error messages
Improve parser error messages
-----------------------------
Key: HIVE-2012
URL: https://issues.apache.org/jira/browse/HIVE-2012
Project: Hive
Issue Type: Bug
Components: Diagnosability, Query Processor
Reporter: Carl Steinbach
This is a place for accumulating error message improvements for the Hive parser so that we can update a bunch in batch.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2012) Improve parser error messages
Posted by "Holden Karau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030442#comment-13030442 ]
Holden Karau commented on HIVE-2012:
------------------------------------
Hi Carl,
I think you are mistaken as to what is causing the problem. The name 'LINES' is a reserved token, hence it is not a valid identifier. For example if you try create table lines(line string) you will see the same error message. The request for a valid identifier by the parser is correct. I will look at adding a patch which outputs the token which is not a valid identifier if this case so that when a reserved word is used it is clearer.
Cheers,
Holden
P.S.
I could be wrong this is my first time digging through the hive code.
> Improve parser error messages
> -----------------------------
>
> Key: HIVE-2012
> URL: https://issues.apache.org/jira/browse/HIVE-2012
> Project: Hive
> Issue Type: Bug
> Components: Diagnosability, Query Processor
> Reporter: Carl Steinbach
>
> This is a place for accumulating error message improvements for the Hive parser so that we can update a bunch in batch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2012) Improve parser error messages
Posted by "Holden Karau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Holden Karau updated HIVE-2012:
-------------------------------
Attachment: HIVE-2012.1.patch
I tried to create a reviewboard account, but registration seems to be broken. I've attached a patch which should result in a clearer error message.
> Improve parser error messages
> -----------------------------
>
> Key: HIVE-2012
> URL: https://issues.apache.org/jira/browse/HIVE-2012
> Project: Hive
> Issue Type: Bug
> Components: Diagnosability, Query Processor
> Reporter: Carl Steinbach
> Attachments: HIVE-2012.1.patch
>
>
> This is a place for accumulating error message improvements for the Hive parser so that we can update a bunch in batch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-2012) Improve parser error messages
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000570#comment-13000570 ]
Carl Steinbach commented on HIVE-2012:
--------------------------------------
{code}
create table lines(string line)
PARTITIONED BY (rownum BIGINT)
STORED AS SEQUENCEFILE;
FAILED: Parse Error:
line 1:13 mismatched input 'lines' expecting Identifier in create statement
^^^^^^^^^^
{code}
Instead of saying "Identifier", it should say "Type" or "column type".
> Improve parser error messages
> -----------------------------
>
> Key: HIVE-2012
> URL: https://issues.apache.org/jira/browse/HIVE-2012
> Project: Hive
> Issue Type: Bug
> Components: Diagnosability, Query Processor
> Reporter: Carl Steinbach
>
> This is a place for accumulating error message improvements for the Hive parser so that we can update a bunch in batch.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira