You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/12 14:45:26 UTC
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2712: docs: add create/update_time fields
juzhiyuan commented on a change in pull request #2712:
URL: https://github.com/apache/apisix/pull/2712#discussion_r522158589
##########
File path: doc/admin-api.md
##########
@@ -513,7 +519,9 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst
|desc |optional|upstream usage scenarios, and more.|
|pass_host |optional|`pass` pass the client request host, `node` not pass the client request host, using the upstream node host, `rewrite` rewrite host by the configured `upstream_host`.|
|upstream_host |optional|This option is only valid if the `pass_host` is `rewrite`.|
-|labels|False |Match Rules|Key/value pairs to specify attributes|{"version":"v2","build":"16","env":"production"}|
+|labels|optional |Key/value pairs to specify attributes|{"version":"v2","build":"16","env":"production"}|
+|create_time|optional| epoch timestamp in second, like `1602883670`|
+|update_time|optional| epoch timestamp in second, like `1602883670`|
Review comment:
We may format all docs to have a uniform style in the future.
##########
File path: doc/zh-cn/admin-api.md
##########
@@ -528,6 +534,8 @@ APISIX 的 Upstream 除了基本的复杂均衡算法选择外，还支持对上
|pass_host |可选|枚举|`pass` 透传客户端请求的 host, `node` 不透传客户端请求的 host, 使用 upstream node 配置的 host, `rewrite` 使用 `upstream_host` 配置的值重写 host 。||
|upstream_host |可选|辅助|只在 `pass_host` 配置为 `rewrite` 时有效。||
|labels |可选 |匹配规则|标识附加属性的键值对|{"version":"v2","build":"16","env":"production"}|
+|create_time|可选|辅助|单位为秒的 epoch 时间戳|1602883670|
Review comment:
Should we translate the `epoch` word?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org