You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by GitBox <gi...@apache.org> on 2021/04/14 22:24:31 UTC
[GitHub] [openoffice] Pilot-Pirx opened a new pull request #126: Quick fix to get the version string right in the About dialog
Pilot-Pirx opened a new pull request #126:
URL: https://github.com/apache/openoffice/pull/126
This is not really a good solution. But we can use it until someone else has a better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] jimjag merged pull request #126: Fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
jimjag merged pull request #126:
URL: https://github.com/apache/openoffice/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] jimjag commented on pull request #126: Fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
jimjag commented on pull request #126:
URL: https://github.com/apache/openoffice/pull/126#issuecomment-821363664
Approved by me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #126: Quick fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
ardovm commented on pull request #126:
URL: https://github.com/apache/openoffice/pull/126#issuecomment-820674805
I apologize for the forced push. I always have to cherry-pick two commits from trunk in order to build AOO41X on openSUSE and I included them by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] Pilot-Pirx commented on pull request #126: Fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
Pilot-Pirx commented on pull request #126:
URL: https://github.com/apache/openoffice/pull/126#issuecomment-821251804
> I suggest we squash the commits when merging to avoid polluting the commit log.
Please go ahead, it is your code! ;-) Squash and merge will be best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #126: Quick fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
ardovm commented on pull request #126:
URL: https://github.com/apache/openoffice/pull/126#issuecomment-820677389
This code is an attempt to glue two strings together, avoiding to repeat the common part in between. In order not to make a generic algorithm, that would be overkill (such as trying with one character, then with two, then with three etc.) we have to make some assumptions. The assumption is that the product source is always "AOOsomething" -- i.e. the "something" part starts at the fourth character.
I tried to find the definition of the "product source", but after passing from C++ to XML, to Perl, I got lost in the configure script and surrendered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] Pilot-Pirx commented on pull request #126: Quick fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
Pilot-Pirx commented on pull request #126:
URL: https://github.com/apache/openoffice/pull/126#issuecomment-820675967
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on a change in pull request #126: Quick fix to get the version string right in the About dialog
Posted by GitBox <gi...@apache.org>.
ardovm commented on a change in pull request #126:
URL: https://github.com/apache/openoffice/pull/126#discussion_r614337486
##########
File path: main/cui/source/dialogs/about.cxx
##########
@@ -502,13 +502,14 @@ const rtl::OUString AboutDialog::GetBuildId() const
// For better readability, strip the duplicate ProductMajor ("340").
if ( sProductSource.getLength() )
{
+ sal_Int32 versionLength = sProductSource.getLength() - 3;
Review comment:
Actually, this should be named "productMajorLength" to be consistent with the above comment. It's probably worth renaming for the sake of clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org