You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by gb...@apache.org on 2023/06/06 22:41:28 UTC

svn commit: r1910269 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/ssl/ssl_util_ocsp.c

Author: gbechis
Date: Tue Jun  6 22:41:27 2023
New Revision: 1910269

URL: http://svn.apache.org/viewvc?rev=1910269&view=rev
Log:
log an error if BIO_write(3) fails

Modified:
    httpd/httpd/trunk/docs/log-message-tags/next-number
    httpd/httpd/trunk/modules/ssl/ssl_util_ocsp.c

Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1910269&r1=1910268&r2=1910269&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
+++ httpd/httpd/trunk/docs/log-message-tags/next-number Tue Jun  6 22:41:27 2023
@@ -1 +1 @@
-10455
+10456

Modified: httpd/httpd/trunk/modules/ssl/ssl_util_ocsp.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_util_ocsp.c?rev=1910269&r1=1910268&r2=1910269&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ssl/ssl_util_ocsp.c (original)
+++ httpd/httpd/trunk/modules/ssl/ssl_util_ocsp.c Tue Jun  6 22:41:27 2023
@@ -287,7 +287,10 @@ static OCSP_RESPONSE *read_response(apr_
                       "OCSP response: got %" APR_SIZE_T_FMT
                       " bytes, %" APR_SIZE_T_FMT " total", len, count);
 
-        BIO_write(bio, data, (int)len);
+        if(BIO_write(bio, data, (int)len) < 0) {
+          ap_log_cerror(APLOG_MARK, APLOG_ERR, 0, c, APLOGNO(10455)
+                      "failed to write OCSP response to BIO buffer");
+        }
         apr_bucket_delete(e);
     }