You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/18 06:12:53 UTC
[GitHub] [pulsar-client-go] Anonymitaet commented on a change in pull request #254: Fix send async comments
Anonymitaet commented on a change in pull request #254:
URL: https://github.com/apache/pulsar-client-go/pull/254#discussion_r426388616
##########
File path: pulsar/producer.go
##########
@@ -128,6 +128,8 @@ type Producer interface {
Send(context.Context, *ProducerMessage) (MessageID, error)
// SendAsync a message in asynchronous mode
+ // This call will be blocking when the `event channel` becomes full (default: 10) or the
Review comment:
```suggestion
// This call is blocked when the `event channel` becomes full (default: 10) or the
```
What's the unit for "10"? 10 MB or 10 messages?
##########
File path: pulsar/producer.go
##########
@@ -128,6 +128,8 @@ type Producer interface {
Send(context.Context, *ProducerMessage) (MessageID, error)
// SendAsync a message in asynchronous mode
+ // This call will be blocking when the `event channel` becomes full (default: 10) or the
+ // maxPendingMessages becomes full (default: 1000)
Review comment:
```suggestion
// `maxPendingMessages` becomes full (default: 1000)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org