[GitHub] [solr] risdenk commented on a diff in pull request #1301: SOLR-16627: Upgrade google-cloud-bom to 0.184.0, re2j to 1.6, and grpc to 1.51.0

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1301:
URL: https://github.com/apache/solr/pull/1301#discussion_r1073986526


##########
solr/modules/gcs-repository/src/test/org/apache/solr/gcs/ConcurrentDelegatingStorage.java:
##########
@@ -56,6 +56,7 @@
  * synchronization across all instance methods. This allows google-cloud-nio's in-memory fake to be
  * used from multiple threads simultaneously as our tests require.
  */
+@SuppressWarnings("try")

Review Comment:
   This is necessary since apparently Storage added a default close method that `throws Exception` which includes `InterruptedException` and thats expected from the Javadoc. This suppresses that warning that fails the build. The warning is coming from the compiler itself saying that close should never throw `InterruptedException` but apparently the `Storage` interface thinks otherwise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org