You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/26 10:08:03 UTC

[GitHub] [inlong] Yizhou-Yang commented on a diff in pull request #7062: [INLONG-7061][Sort] Support table level metrics for Apache Doris connector and add dirty metrics

Yizhou-Yang commented on code in PR #7062:
URL: https://github.com/apache/inlong/pull/7062#discussion_r1057173838


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -486,6 +497,17 @@ private void handleDirtyData(Object dirtyData, DirtyType dirtyType, Exception e)
             }
             throw ex;
         }
+
+        if (multipleSink) {
+            String[] tableWithDb = tableIdentifier.split("\\.");

Review Comment:
   the table identifier.split is used for multiple sink regular out data count, so I think it works for dirty data too...? or is there something i missed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org