You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/12 07:06:46 UTC

[GitHub] [apisix] spacewander opened a new pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

spacewander opened a new pull request #2396:
URL: https://github.com/apache/apisix/pull/2396


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2396:
URL: https://github.com/apache/apisix/pull/2396#issuecomment-706921843


   Here is the backtrace of error.log when you try to access the prometheus path and config center is not etcd:
   ```
   .../incubator-apisix/apisix/plugins/prometheus/exporter.lua:298: attempt to call method 'getkey' (a nil value)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #2396:
URL: https://github.com/apache/apisix/pull/2396#issuecomment-706925687


   @spacewander is it about #2394 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander edited a comment on pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

Posted by GitBox <gi...@apache.org>.
spacewander edited a comment on pull request #2396:
URL: https://github.com/apache/apisix/pull/2396#issuecomment-706946268


   @idbeta 
   Look like they are two difference issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #2396:
URL: https://github.com/apache/apisix/pull/2396#issuecomment-706992762


   @spacewander I see.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2396:
URL: https://github.com/apache/apisix/pull/2396#issuecomment-706946268


   @idbeta 
   Look like they are two difference issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2396: fix(prometheus): don't provide etcd metrics when you don't use it

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2396:
URL: https://github.com/apache/apisix/pull/2396


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org