You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "tetebueno (via GitHub)" <gi...@apache.org> on 2024/10/24 14:15:04 UTC
[PR] Adding Dvorak ES keyboard layout [guacamole-client]
tetebueno opened a new pull request, #1031:
URL: https://github.com/apache/guacamole-client/pull/1031
Adding support for Spanish Dvorak keyboard layout included in Ubuntu distributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding Dvorak ES keyboard layout [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1031:
URL: https://github.com/apache/guacamole-client/pull/1031#issuecomment-2435490494
As mentioned on apache/guacamole-server#562, you'll need to create that Jira issue (and a Jira account, if you don't already have it), and tag the PR and commits with that information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1996: Adding Dvorak ES keyboard layout [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #1031:
URL: https://github.com/apache/guacamole-client/pull/1031#discussion_r1815607355
##########
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json:
##########
@@ -109,6 +109,7 @@
"en-gb-qwerty",
"en-us-qwerty",
"es-es-qwerty",
+ "es-es-dvorak",
Review Comment:
This is a minor thing, but `es-es-dvorak` should be _above_ `es-es-qwerty`, alphabetically - here, and in the other files you've updated in the client code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1996: Adding Dvorak ES keyboard layout [guacamole-client]
Posted by "tetebueno (via GitHub)" <gi...@apache.org>.
tetebueno commented on code in PR #1031:
URL: https://github.com/apache/guacamole-client/pull/1031#discussion_r1815662594
##########
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json:
##########
@@ -109,6 +109,7 @@
"en-gb-qwerty",
"en-us-qwerty",
"es-es-qwerty",
+ "es-es-dvorak",
Review Comment:
Done. Now checking how to fix server's PR build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1996: Adding Dvorak ES keyboard layout [guacamole-client]
Posted by "tetebueno (via GitHub)" <gi...@apache.org>.
tetebueno commented on PR #1031:
URL: https://github.com/apache/guacamole-client/pull/1031#issuecomment-2605531133
Marking as draft as https://github.com/apache/guacamole-server/pull/562.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1996: Adding Dvorak ES keyboard layout [guacamole-client]
Posted by "tetebueno (via GitHub)" <gi...@apache.org>.
tetebueno commented on PR #1031:
URL: https://github.com/apache/guacamole-client/pull/1031#issuecomment-2436147704
Just generated the following issue: https://issues.apache.org/jira/projects/GUACAMOLE/issues/GUACAMOLE-1996?filter=allopenissues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org