[GitHub] [aurora] StephanErb commented on a change in pull request #67: Adding flag to enable SLA aware killing for non production workloads.

[GitBox <gi...@apache.org>]

StephanErb commented on a change in pull request #67: Adding flag to enable SLA aware killing for non production workloads.
URL: https://github.com/apache/aurora/pull/67#discussion_r321220330
 
 

 ##########
 File path: src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java
 ##########
 @@ -445,8 +449,7 @@ private void incrementErrorCount(String prefix, String taskKey) {
   }
 
   private boolean skipSla(IScheduledTask task, long numActive) {
-    if (!tierManager.getTier(task.getAssignedTask().getTask()).isPreemptible()
-        && !tierManager.getTier(task.getAssignedTask().getTask()).isRevocable()) {
+    if (slaAwareKillNonProd || task.getAssignedTask().getTask().isProduction()) {
 
 Review comment:
   The production flag is deprecated so we need to keep on using `isRevocable` and `isPreemptible` here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services