You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/26 09:45:52 UTC
[GitHub] [skywalking] daiqianshi opened a new issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
daiqianshi opened a new issue #6455:
URL: https://github.com/apache/skywalking/issues/6455
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
___
### Bug
- Which version of SkyWalking, OS, and JRE?
SkyWalking:8.3.0, OS:Centos, java:1.8.0_221
- What happened?
The error only returned by ES database,Mysql is ok. Is there any additional configuration I need to add?
```json
{
"errors": [{
"message": "Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)"
}, {
"message": "Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[1]/name)"
}]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] daiqianshi commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
daiqianshi commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-786556859
Thank you for your answer, Where can I configure or add *slowStatementBuilder#statement != null* @wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-786538660
I think you need to open `TRACE_DSL` for your elasticsearch plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-787410207
Yes, and no /
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-787404958
https://github.com/apache/skywalking/blob/19d4a77235de37f47c3b97cff0118fddbdb565e3/oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java#L206-L210
@wu-sheng `StringUtil.isEmpty(sqlStatement)` check move out of the loop , can it be changed like this?
```
if (StringUtil.isEmpty(slowStatementBuilder.getStatement())) {
slowStatementBuilder.setStatement("[No statement]/" + span.getOperationName());
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-786625506
This is a code change, you can't config it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-786539546
`MultiScopesAnalysisListener` should add `slowStatementBuilder#statement != null` check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-787406843
Make sense, I think we should also check check operation name is null. Because I remember there is a case, people said they have `[No statement]/null` on the UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6455:
URL: https://github.com/apache/skywalking/issues/6455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-786628418
@daiqianshi If you are willing to read codes, and submit pull request, read `MultiScopesAnalysisListener.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6455: Database Slow Statements return error:Cannot return null for non-nullable type: 'String' within parent 'SelectedRecord' (/readSampledRecords[0]/name)
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6455:
URL: https://github.com/apache/skywalking/issues/6455#issuecomment-787407444
> Make sense, I think we should also check check operation name is null. Because I remember there is a case, people said they have `[No statement]/null` on the UI.
Replace null with "" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org