You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/05/26 12:11:26 UTC

[PR] [fix](env) fix beut build [doris]

Mryange opened a new pull request, #63691:
URL: https://github.com/apache/doris/pull/63691

   ### What problem does this PR solve?
   
   
   ```
   ../src/core/assert_cast.h:54:19: error: static assertion failed due to requirement '!std::is_same_v<doris::ColumnVector<doris::TYPE_BOOLEAN> *, doris::ColumnVector<doris::TYPE_BOOLEAN> *>': assert_cast is redundant for the same type after removing cv/ref qualifiers
      54 |     static_assert(!std::is_same_v<AssertCastNormalizedType_t<To>, AssertCastNormalizedType_t<From>>,
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../test/exprs/function/geo/functions_geo_test.cpp:375:5: note: in instantiation of function template specialization 'assert_cast<doris::ColumnVector<doris::TYPE_BOOLEAN> *, TypeCheckOnRelease::ENABLE, doris::ColumnVector<doris::TYPE_BOOLEAN> *>' requested here
     375 |     assert_cast<ColumnUInt8*>(nullable_input->get_null_map_column_ptr().get())->insert_value(0);
         |     ^
   1 error generated.
   ```
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4543978512

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4545167795

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172643 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit f70469247fb2f169700d20bbdf2cdb91ee7155e1, data reload: false
   
   query5	4300	660	523	523
   query6	335	216	194	194
   query7	4293	584	327	327
   query8	328	237	229	229
   query9	8835	4139	4110	4110
   query10	486	348	300	300
   query11	5778	2404	2195	2195
   query12	182	132	127	127
   query13	1289	616	443	443
   query14	6131	5517	5346	5346
   query14_1	4539	4545	4553	4545
   query15	219	205	187	187
   query16	1025	479	435	435
   query17	988	753	619	619
   query18	2470	497	383	383
   query19	232	205	171	171
   query20	137	137	132	132
   query21	219	140	129	129
   query22	13701	13730	13402	13402
   query23	17400	16648	16298	16298
   query23_1	16286	16352	16364	16352
   query24	7543	1777	1307	1307
   query24_1	1322	1310	1333	1310
   query25	599	514	450	450
   query26	1305	330	178	178
   query27	2683	545	351	351
   query28	4456	2025	2031	2025
   query29	1012	652	518	518
   query30	315	240	204	204
   query31	1134	1089	961	961
   query32	92	80	76	76
   query33	560	369	313	313
   query34	1168	1160	679	679
   query35	773	791	686	686
   query36	1393	1425	1261	1261
   query37	148	108	90	90
   query38	3232	3179	3070	3070
   query39	952	922	895	895
   query39_1	866	904	882	882
   query40	244	158	124	124
   query41	65	63	67	63
   query42	109	107	108	107
   query43	330	338	294	294
   query44	
   query45	219	205	203	203
   query46	1085	1204	758	758
   query47	2328	2362	2223	2223
   query48	406	405	295	295
   query49	644	517	379	379
   query50	1001	352	254	254
   query51	4381	4348	4309	4309
   query52	103	110	92	92
   query53	255	285	205	205
   query54	314	268	246	246
   query55	91	89	84	84
   query56	295	308	294	294
   query57	1447	1418	1311	1311
   query58	295	263	273	263
   query59	1614	1719	1432	1432
   query60	320	334	315	315
   query61	161	160	158	158
   query62	701	669	585	585
   query63	245	200	219	200
   query64	2461	788	659	659
   query65	
   query66	1702	469	374	374
   query67	29837	29721	29643	29643
   query68	
   query69	461	360	346	346
   query70	1083	1023	1018	1018
   query71	318	277	273	273
   query72	2990	2743	2408	2408
   query73	828	783	427	427
   query74	5103	4963	4827	4827
   query75	2703	2615	2272	2272
   query76	2287	1162	778	778
   query77	411	422	336	336
   query78	12498	12427	11830	11830
   query79	1466	1031	793	793
   query80	680	541	460	460
   query81	453	292	241	241
   query82	1380	166	121	121
   query83	353	283	253	253
   query84	306	145	116	116
   query85	894	559	453	453
   query86	398	326	339	326
   query87	3442	3388	3242	3242
   query88	3648	2733	2750	2733
   query89	460	391	341	341
   query90	1998	185	182	182
   query91	178	178	138	138
   query92	86	77	74	74
   query93	1537	1431	841	841
   query94	534	356	302	302
   query95	677	385	433	385
   query96	1106	787	352	352
   query97	2714	2731	2599	2599
   query98	230	231	235	231
   query99	1194	1162	1028	1028
   Total cold run time: 254779 ms
   Total hot run time: 172643 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4545063740

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31748 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit f70469247fb2f169700d20bbdf2cdb91ee7155e1, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17689	4077	4088	4077
   q2	q3	10866	1366	804	804
   q4	4698	485	345	345
   q5	7614	2273	2070	2070
   q6	241	175	136	136
   q7	967	752	634	634
   q8	9391	1807	1603	1603
   q9	5100	4945	4942	4942
   q10	6386	2183	1926	1926
   q11	432	283	243	243
   q12	623	447	307	307
   q13	18184	3372	2770	2770
   q14	267	260	250	250
   q15	q16	798	781	707	707
   q17	1002	984	990	984
   q18	6692	5659	5568	5568
   q19	1305	1248	1097	1097
   q20	617	435	297	297
   q21	6389	2810	2629	2629
   q22	468	459	359	359
   Total cold run time: 99729 ms
   Total hot run time: 31748 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4970	4944	4910	4910
   q2	q3	4900	5260	4609	4609
   q4	2190	2233	1420	1420
   q5	5025	4780	4730	4730
   q6	228	179	134	134
   q7	1911	1789	1584	1584
   q8	2483	2124	2183	2124
   q9	7890	7638	7420	7420
   q10	4789	4729	4250	4250
   q11	544	393	358	358
   q12	746	750	544	544
   q13	2986	3395	2785	2785
   q14	268	294	255	255
   q15	q16	702	714	597	597
   q17	1301	1271	1261	1261
   q18	7156	6862	6818	6818
   q19	1092	1114	1112	1112
   q20	2236	2253	1952	1952
   q21	5351	4649	4629	4629
   q22	533	456	418	418
   Total cold run time: 57301 ms
   Total hot run time: 51910 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen closed pull request #63691: [fix](env) fix beut build
URL: https://github.com/apache/doris/pull/63691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4550586488

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4546337151

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63691_f70469247fb2f169700d20bbdf2cdb91ee7155e1_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63691_f70469247fb2f169700d20bbdf2cdb91ee7155e1_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.80% (28066/38028) |
   | Line Coverage     | 57.75% (304841/527849) |
   | Region Coverage   | 54.87% (254956/464619) |
   | Branch Coverage   | 56.40% (110171/195337) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4544890802

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4544153334

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #63691:
URL: https://github.com/apache/doris/pull/63691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4543976456

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4543977388

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4550586532

   skip buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](env) fix beut build [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63691:
URL: https://github.com/apache/doris/pull/63691#issuecomment-4544153078

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org