You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by gemmellr <gi...@git.apache.org> on 2016/08/25 15:30:06 UTC
[GitHub] qpid-proton pull request #79: PROTON-1224: support newer BouncyCastle versio...
GitHub user gemmellr opened a pull request:
https://github.com/apache/qpid-proton/pull/79
PROTON-1224: support newer BouncyCastle versions
Update based on PR #78
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gemmellr/qpid-proton bouncycastle-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 0642fa59caa0e62bb19485b83248ca65d91e213f
Author: Jem Day <jd...@paypal.com>
Date: 2016-08-22T20:37:39Z
PROTON-1224: Support newer BouncyCastle Implementations
Support new version of BouncyCastle library via existing reflection
mechanism.
Added Unit-tests
commit 24873ebd1191af7b03937fa93329458c69eb80b7
Author: Robert Gemmell <ro...@apache.org>
Date: 2016-08-25T14:48:06Z
PROTON-1224: rework loading of bouncycastle to ensure failure is detected, but suppressed since its optional, and actually reported at the point usage would fail. Fix up various whitespace etc issues.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #79: PROTON-1224: support newer BouncyCastle versions
Posted by JemDay <gi...@git.apache.org>.
Github user JemDay commented on the issue:
https://github.com/apache/qpid-proton/pull/79
Robbie
Thanks, i've taken a quick look and nothing leaps out at me, i'll try pulling this down and checking locally. I will try and get to this today but it might stretch to tomorrow.
I'd also like to discuss off-line another enhancement we'd like to make whereby we can provide/inject an SSLContext directly - this is the way we can conform with our in-house security constraints and mechanisms.
Jem..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #79: PROTON-1224: support newer BouncyCastle versio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #79: PROTON-1224: support newer BouncyCastle versions
Posted by JemDay <gi...@git.apache.org>.
Github user JemDay commented on the issue:
https://github.com/apache/qpid-proton/pull/79
Robbie..
As-per JIRA comment we were able to verify functionality with successful connections to a dispatch-router network.
Looks good, thanks for your patience.
J--
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #79: PROTON-1224: support newer BouncyCastle versions
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton/pull/79
@JemDay I've made some updates to your patch, if youd like to give things a look over and try out and let me know how you get on that would be good, then I can merge it (might squash things first, left them separate for now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org