You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/01 13:48:00 UTC
Review Request 70983: Added to the scheduler driver a method to
suppress a subset of roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70983/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
This patch adds to the scheduler driver a 'suppressOffers(roles)'
method, which sends the SUPPRESS call for these roles and adds them to
the suppressed roles set.
Diffs
-----
include/mesos/scheduler.hpp 8c6774885ceb3b0644c32842a17fba39e2c3e472
src/sched/sched.cpp e6cc534264e3ff4edaa703a660afb2f896388802
Diff: https://reviews.apache.org/r/70983/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70983: Added to the scheduler driver a method to
suppress a subset of roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70983/#review216299
-----------------------------------------------------------
Ditto the updated comment on https://reviews.apache.org/r/70941/, sorry for the run-around!
- Benjamin Mahler
On July 1, 2019, 1:47 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70983/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 1:47 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds to the scheduler driver a 'suppressOffers(roles)'
> method, which sends the SUPPRESS call for these roles and adds them to
> the suppressed roles set.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 8c6774885ceb3b0644c32842a17fba39e2c3e472
> src/sched/sched.cpp e6cc534264e3ff4edaa703a660afb2f896388802
>
>
> Diff: https://reviews.apache.org/r/70983/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70983: Added to the scheduler driver a method to
suppress a subset of roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70983/#review216367
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 3, 2019, 5:05 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70983/
> -----------------------------------------------------------
>
> (Updated July 3, 2019, 5:05 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds to the scheduler driver a 'suppressOffers(roles)'
> method, which sends the SUPPRESS call for these roles and adds them to
> the suppressed roles set.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 0a09d5505ed2f9f65897ecce44cffa75db624ef4
> src/sched/sched.cpp 6b02ac071c9773411954636730c953cca0044516
>
>
> Diff: https://reviews.apache.org/r/70983/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70983: Added to the scheduler driver a method to
suppress a subset of roles.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70983/
-----------------------------------------------------------
(Updated July 3, 2019, 5:05 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Made suppressing an empty vector of roles a no-op.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
This patch adds to the scheduler driver a 'suppressOffers(roles)'
method, which sends the SUPPRESS call for these roles and adds them to
the suppressed roles set.
Diffs (updated)
-----
include/mesos/scheduler.hpp 0a09d5505ed2f9f65897ecce44cffa75db624ef4
src/sched/sched.cpp 6b02ac071c9773411954636730c953cca0044516
Diff: https://reviews.apache.org/r/70983/diff/2/
Changes: https://reviews.apache.org/r/70983/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko