You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 06:57:15 UTC
[GitHub] [spark] chaojun-zhang opened a new pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
chaojun-zhang opened a new pull request #31722:
URL: https://github.com/apache/spark/pull/31722
### What changes were proposed in this pull request?
This pr make DPP support RLIKE expression:
```sql
SELECT date_id, product_id FROM fact_sk f
JOIN dim_store s
ON f.store_id = s.store_id WHERE s.country RLIKE '[DE|US]'
```
### Why are the changes needed?
Improve query performance.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791124523
**[Test build #135790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135790/testReport)** for PR 31722 at commit [`d888091`](https://github.com/apache/spark/commit/d888091151ffc74e06c506feeab517ec0acb2784).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791919561
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791229423
**[Test build #135790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135790/testReport)** for PR 31722 at commit [`d888091`](https://github.com/apache/spark/commit/d888091151ffc74e06c506feeab517ec0acb2784).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791234755
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135790/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789769111
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40290/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maryannxue commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
maryannxue commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-792920307
Thank for pinging me, @HyukjinKwon ! Late LGTM here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789933221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135708/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789691790
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789708825
**[Test build #135708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135708/testReport)** for PR 31722 at commit [`f5c0504`](https://github.com/apache/spark/commit/f5c0504b926c6e82edc083fa6aefe8dec0d98fa1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790328671
**[Test build #135738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135738/testReport)** for PR 31722 at commit [`b7d2172`](https://github.com/apache/spark/commit/b7d217251f1476dc4ede084c26e1d8c322730ed4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790502667
**[Test build #135738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135738/testReport)** for PR 31722 at commit [`b7d2172`](https://github.com/apache/spark/commit/b7d217251f1476dc4ede084c26e1d8c322730ed4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790405397
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40320/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31722:
URL: https://github.com/apache/spark/pull/31722#discussion_r587217340
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,32 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country RLIKE '[DE|US]'
Review comment:
nit: extra unnecessary spaces between `RLIKE` and `'[DE...`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,32 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country RLIKE '[DE|US]'
+ """.stripMargin)
+
+ checkPartitionPruningPredicate(df, false, true)
+
+ checkAnswer(df,
+ Row(1030, 2) ::
+ Row(1040, 2) ::
+ Row(1050, 2) ::
+ Row(1060, 2) ::
+ Row(1070, 2) ::
+ Row(1080, 3) ::
+ Row(1090, 3) ::
+ Row(1100, 3) ::
+ Row(1110, 3) ::
+ Row(1120, 4) :: Nil
Review comment:
nit: should be same indentation as other test cases in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789731008
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40290/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #31722:
URL: https://github.com/apache/spark/pull/31722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789486570
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789486570
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789755390
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40290/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791124523
**[Test build #135790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135790/testReport)** for PR 31722 at commit [`d888091`](https://github.com/apache/spark/commit/d888091151ffc74e06c506feeab517ec0acb2784).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790328671
**[Test build #135738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135738/testReport)** for PR 31722 at commit [`b7d2172`](https://github.com/apache/spark/commit/b7d217251f1476dc4ede084c26e1d8c322730ed4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790525339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135738/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790525339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135738/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chaojun-zhang commented on a change in pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
chaojun-zhang commented on a change in pull request #31722:
URL: https://github.com/apache/spark/pull/31722#discussion_r587135735
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,50 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support Like/RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country LIKE '%D%'
+ """.stripMargin)
+
+ checkPartitionPruningPredicate(df, false, true)
+
+ checkAnswer(df,
+ Row(1030, 2) ::
+ Row(1040, 2) ::
+ Row(1050, 2) ::
+ Row(1060, 2) :: Nil
+ )
Review comment:
Ok, I will remove this part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chaojun-zhang commented on a change in pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
chaojun-zhang commented on a change in pull request #31722:
URL: https://github.com/apache/spark/pull/31722#discussion_r587991483
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,32 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country RLIKE '[DE|US]'
+ """.stripMargin)
+
+ checkPartitionPruningPredicate(df, false, true)
+
+ checkAnswer(df,
+ Row(1030, 2) ::
+ Row(1040, 2) ::
+ Row(1050, 2) ::
+ Row(1060, 2) ::
+ Row(1070, 2) ::
+ Row(1080, 3) ::
+ Row(1090, 3) ::
+ Row(1100, 3) ::
+ Row(1110, 3) ::
+ Row(1120, 4) :: Nil
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791118865
Looks fine to me too. It would be great if @maryannxue could have a chance to take a quick look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789769111
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40290/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789708825
**[Test build #135708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135708/testReport)** for PR 31722 at commit [`f5c0504`](https://github.com/apache/spark/commit/f5c0504b926c6e82edc083fa6aefe8dec0d98fa1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789926479
**[Test build #135708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135708/testReport)** for PR 31722 at commit [`f5c0504`](https://github.com/apache/spark/commit/f5c0504b926c6e82edc083fa6aefe8dec0d98fa1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789670154
ok to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-790405397
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40320/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chaojun-zhang commented on a change in pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
chaojun-zhang commented on a change in pull request #31722:
URL: https://github.com/apache/spark/pull/31722#discussion_r587991429
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,32 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country RLIKE '[DE|US]'
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31722:
URL: https://github.com/apache/spark/pull/31722#discussion_r587106293
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,50 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support Like/RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country LIKE '%D%'
+ """.stripMargin)
+
+ checkPartitionPruningPredicate(df, false, true)
+
+ checkAnswer(df,
+ Row(1030, 2) ::
+ Row(1040, 2) ::
+ Row(1050, 2) ::
+ Row(1060, 2) :: Nil
+ )
Review comment:
We already have this LIKE-case test in the existing code? If it exists, I think we don't need this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chaojun-zhang commented on a change in pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
chaojun-zhang commented on a change in pull request #31722:
URL: https://github.com/apache/spark/pull/31722#discussion_r587189953
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1403,6 +1403,50 @@ abstract class DynamicPartitionPruningSuiteBase
)
}
}
+
+ test("SPARK-34436: DPP support Like/RLike expression") {
+ withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+ val df = sql(
+ """
+ |SELECT date_id, product_id FROM fact_sk f
+ |JOIN dim_store s
+ |ON f.store_id = s.store_id WHERE s.country LIKE '%D%'
+ """.stripMargin)
+
+ checkPartitionPruningPredicate(df, false, true)
+
+ checkAnswer(df,
+ Row(1030, 2) ::
+ Row(1040, 2) ::
+ Row(1050, 2) ::
+ Row(1060, 2) :: Nil
+ )
Review comment:
Fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-789933221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135708/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791120314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31722: [SPARK-34595][SQL] DPP support RLIKE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31722:
URL: https://github.com/apache/spark/pull/31722#issuecomment-791120314
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40372/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org