You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/08/18 17:25:11 UTC
[superset] branch hugh/show-full-error-for-reports created (now
f8d9614)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch hugh/show-full-error-for-reports
in repository https://gitbox.apache.org/repos/asf/superset.git.
at f8d9614 remove extra idx reference
This branch includes the following new commits:
new 40dbdb3 don't maniuplate error message
new f8d9614 remove extra idx reference
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/02: don't maniuplate error message
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/show-full-error-for-reports
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 40dbdb3b00b283367df3e398131eb6bfaf81a624
Author: hughhhh <hu...@gmail.com>
AuthorDate: Wed Aug 18 13:09:32 2021 -0400
don't maniuplate error message
---
superset-frontend/src/reports/actions/reports.js | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/reports/actions/reports.js b/superset-frontend/src/reports/actions/reports.js
index c7eb0c9..46c8934 100644
--- a/superset-frontend/src/reports/actions/reports.js
+++ b/superset-frontend/src/reports/actions/reports.js
@@ -110,11 +110,12 @@ export const addReport = report => dispatch => {
.catch(async e => {
const parsedError = await getClientErrorObject(e);
const errorMessage = parsedError.message;
- const errorArr = Object.keys(errorMessage);
- const error = errorMessage[errorArr[0]][0];
+ // Do we need this?
+ // const errorArr = Object.keys(errorMessage);
+ // const error = errorMessage[errorArr[0]][0];
dispatch(
addDangerToast(
- t('An error occurred while editing this report: %s', error),
+ t('An error occurred while editing this report: %s', errorMessage),
),
);
});
[superset] 02/02: remove extra idx reference
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/show-full-error-for-reports
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f8d9614062438a78233e1a7d35e3cf980482c91e
Author: hughhhh <hu...@gmail.com>
AuthorDate: Wed Aug 18 13:21:21 2021 -0400
remove extra idx reference
---
superset-frontend/src/reports/actions/reports.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/reports/actions/reports.js b/superset-frontend/src/reports/actions/reports.js
index 46c8934..adcb805 100644
--- a/superset-frontend/src/reports/actions/reports.js
+++ b/superset-frontend/src/reports/actions/reports.js
@@ -17,6 +17,7 @@
* under the License.
*/
/* eslint camelcase: 0 */
+import { ConsoleSqlOutlined } from '@ant-design/icons';
import { t, SupersetClient } from '@superset-ui/core';
import rison from 'rison';
import { getClientErrorObject } from 'src/utils/getClientErrorObject';
@@ -110,12 +111,11 @@ export const addReport = report => dispatch => {
.catch(async e => {
const parsedError = await getClientErrorObject(e);
const errorMessage = parsedError.message;
- // Do we need this?
- // const errorArr = Object.keys(errorMessage);
- // const error = errorMessage[errorArr[0]][0];
+ const errorArr = Object.keys(errorMessage);
+ const error = errorMessage[errorArr[0]];
dispatch(
addDangerToast(
- t('An error occurred while editing this report: %s', errorMessage),
+ t('An error occurred while editing this report: %s', error),
),
);
});