You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/03 14:23:00 UTC
[jira] [Commented] (IGNITE-9428) MVCC TX:
MvccQueryTrackerImpl.onDone() semantic is broken.
[ https://issues.apache.org/jira/browse/IGNITE-9428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602229#comment-16602229 ]
ASF GitHub Bot commented on IGNITE-9428:
----------------------------------------
GitHub user AMashenkov opened a pull request:
https://github.com/apache/ignite/pull/4672
IGNITE-9428: Fix broken MvccQueryTrackerImpl.onDone() semantic.
Signed-off-by: Andrey V. Mashenkov <an...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9428
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4672
----
commit d3989bae08e2f7cdbc8677c4fae021efa7ef41f0
Author: Andrey V. Mashenkov <an...@...>
Date: 2018-09-03T13:06:24Z
IGNITE-9428: Fix broken MvccQueryTrackerImpl.onDone() semantic.
Signed-off-by: Andrey V. Mashenkov <an...@gmail.com>
----
> MVCC TX: MvccQueryTrackerImpl.onDone() semantic is broken.
> ----------------------------------------------------------
>
> Key: IGNITE-9428
> URL: https://issues.apache.org/jira/browse/IGNITE-9428
> Project: Ignite
> Issue Type: Bug
> Components: mvcc, sql
> Reporter: Roman Kondakov
> Assignee: Andrew Mashenkov
> Priority: Major
> Fix For: 2.7
>
>
> Due to IGNITE-9256 patch, multiple {{H2ResultSetIterator#onClose}} invocation becomes possible. This can be considered as a {{Closable}} contract violation and should be fixed.
> Also this case revealed a bug in {{MvccQueryTrackerImpl}} when multiple {{onDone()}} call leads to multiple query finished acks sent back to the {{MvccCoordinator}} which leads to the problems with the query tracking and assertion errors.
> Reproducer: {{CacheMvccSqlTxQueriesAbstractTest#testAccountsTxDmlSumSql_WithRemoves_SingleNode}}
>
> Upd: test was fixed in IGNITE-9373. But MvccQueryTrackerImpl.onDone() issue is still actual.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)