You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "FrankChen021 (via GitHub)" <gi...@apache.org> on 2026/06/02 12:22:27 UTC
Re: [PR] docs: update to docusaurus 3.10 (druid)
FrankChen021 commented on code in PR #19522:
URL: https://github.com/apache/druid/pull/19522#discussion_r3341108864
##########
website/package.json:
##########
@@ -24,20 +24,21 @@
"npm": "10.8.2"
},
"devDependencies": {
- "@docusaurus/module-type-aliases": "3.7.0",
- "@docusaurus/types": "3.7.0",
+ "@docusaurus/module-type-aliases": "3.10.1",
+ "@docusaurus/types": "3.10.1",
"markdown-spellcheck": "^1.3.1",
"postcss": "^8.4.24",
"sass": "^1.62.1"
},
"dependencies": {
- "@docusaurus/core": "^3.7.0",
- "@docusaurus/plugin-client-redirects": "^3.7.0",
- "@docusaurus/preset-classic": "^3.7.0",
- "@docusaurus/theme-mermaid": "^3.7.0",
+ "@docusaurus/core": "^3.10.1",
+ "@docusaurus/plugin-client-redirects": "^3.10.1",
+ "@docusaurus/preset-classic": "^3.10.1",
+ "@docusaurus/theme-mermaid": "^3.10.1",
+ "@docusaurus/faster": "^3.10.1",
Review Comment:
[P2] Regenerate the tracked website lockfile
The PR updates Docusaurus to 3.10.1 and adds @docusaurus/faster plus @mermaid-js/layout-elk, but website/package-lock.json is still tracked with the old 3.7.0 graph and docusaurus@1.14.7. A clean npm ci will reject the out-of-sync manifest/lockfile, and lockfile-based installs will not get the intended dependency graph. Regenerate and commit website/package-lock.json with the repo's npm version.
##########
website/package.json:
##########
@@ -24,20 +24,21 @@
"npm": "10.8.2"
},
"devDependencies": {
- "@docusaurus/module-type-aliases": "3.7.0",
- "@docusaurus/types": "3.7.0",
+ "@docusaurus/module-type-aliases": "3.10.1",
+ "@docusaurus/types": "3.10.1",
"markdown-spellcheck": "^1.3.1",
"postcss": "^8.4.24",
"sass": "^1.62.1"
},
"dependencies": {
- "@docusaurus/core": "^3.7.0",
- "@docusaurus/plugin-client-redirects": "^3.7.0",
- "@docusaurus/preset-classic": "^3.7.0",
- "@docusaurus/theme-mermaid": "^3.7.0",
+ "@docusaurus/core": "^3.10.1",
+ "@docusaurus/plugin-client-redirects": "^3.10.1",
+ "@docusaurus/preset-classic": "^3.10.1",
+ "@docusaurus/theme-mermaid": "^3.10.1",
+ "@docusaurus/faster": "^3.10.1",
"clsx": "^1.1.1",
- "docusaurus": "^1.14.7",
"docusaurus-lunr-search": "^3.6.0",
Review Comment:
[P2] Rewrite legacy Docusaurus scripts after removing v1
The removed docusaurus@1.14.7 package is the provider for legacy binaries like docusaurus-examples, docusaurus-publish, docusaurus-version, docusaurus-rename-version, and docusaurus-write-translations, while the remaining Docusaurus package exposes the docusaurus CLI. After a clean install with the regenerated lockfile, the existing scripts at the top of package.json will fail with command-not-found unless they are converted to Docusaurus 3 CLI forms or removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org