You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/02 17:49:22 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new issue, #2199: servcices/supabase: Tracking issues of not passed test cases
Xuanwo opened a new issue, #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199
```shell
failures:
services_supabase::write_test_create_dir
services_supabase::write_test_create_dir_existing
services_supabase::write_test_delete
services_supabase::write_test_delete_empty_dir
services_supabase::write_test_delete_not_existing
services_supabase::write_test_delete_stream
services_supabase::write_test_delete_with_special_chars
services_supabase::write_test_fuzz_offset_reader
services_supabase::write_test_fuzz_part_reader
services_supabase::write_test_fuzz_range_reader
services_supabase::write_test_read_full
services_supabase::write_test_read_large_range
services_supabase::write_test_read_not_exist
services_supabase::write_test_read_range
services_supabase::write_test_read_with_dir_path
services_supabase::write_test_read_with_special_chars
services_supabase::write_test_reader_from
services_supabase::write_test_reader_range
services_supabase::write_test_reader_tail
services_supabase::write_test_stat
services_supabase::write_test_stat_dir
services_supabase::write_test_stat_not_cleaned_path
services_supabase::write_test_stat_not_exist
services_supabase::write_test_stat_with_special_chars
services_supabase::write_test_write
services_supabase::write_test_write_with_special_chars
test result: FAILED. 101 passed; 26 failed; 0 ignored; 0 measured; 1651 filtered out; finished in 17.56s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532408305
Also, I found that many tests require `read_with_range` capabilities, but the Supabase seems do not support the http RANGE header.
Is it reasonable to add
```Rust
if !op.info().capability().read_with_range {
return Ok(());
}
```
to tests that call into the `op.range_reader()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] servcices/supabase: Tracking issues of not fixed issues at storage-api side [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/opendal/issues/2199#issuecomment-2152251294
We are going to remove supabase support, let's close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532508416
> Supabase has two different storage backend, s3 supports range, but file not. It's another issue from supabase storage side 🤣
>
> ```
> async getObject(
> bucketName: string,
> key: string,
> version: string | undefined
> ): Promise<ObjectResponse> {
> const file = path.resolve(this.filePath, withOptionalVersion(`${bucketName}/${key}`, version))
> const body = fs.createReadStream(file)
> const data = await fs.stat(file)
> const { cacheControl, contentType } = await this.getFileMetadata(file)
> const lastModified = new Date(0)
> lastModified.setUTCMilliseconds(data.mtimeMs)
>
> const checksum = await fileChecksum(file)
>
> return {
> metadata: {
> cacheControl: cacheControl || 'no-cache',
> mimetype: contentType || 'application/octet-stream',
> lastModified: lastModified,
> // contentRange: data.ContentRange, @todo: support range requests
> httpStatusCode: 200,
> size: data.size,
> eTag: checksum,
> contentLength: data.size,
> },
> body,
> }
> }
> ```
What do you think, should we raise an issue there? 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2199: servcices/supabase: Tracking issues of not fixed issues at storage-api side
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1533986799
Thanks to @Ji-Xinyou, most work at opendal side is done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532464488
Supabase has two different storage backend, s3 supports range, but file not:
```
async getObject(
bucketName: string,
key: string,
version: string | undefined
): Promise<ObjectResponse> {
const file = path.resolve(this.filePath, withOptionalVersion(`${bucketName}/${key}`, version))
const body = fs.createReadStream(file)
const data = await fs.stat(file)
const { cacheControl, contentType } = await this.getFileMetadata(file)
const lastModified = new Date(0)
lastModified.setUTCMilliseconds(data.mtimeMs)
const checksum = await fileChecksum(file)
return {
metadata: {
cacheControl: cacheControl || 'no-cache',
mimetype: contentType || 'application/octet-stream',
lastModified: lastModified,
// contentRange: data.ContentRange, @todo: support range requests
httpStatusCode: 200,
size: data.size,
eTag: checksum,
contentLength: data.size,
},
body,
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532396099
Please assign this to me, it is almost done xD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532466932
> Also, I found that many tests require `read_with_range` capabilities, but the Supabase seems do not support the http RANGE header.
>
> Is it reasonable to add
>
> ```rust
> if !op.info().capability().read_with_range {
> return Ok(());
> }
> ```
>
> to tests that call into the `op.range_reader()`?
Yes, we should ignore tests for services that doesn't support range. Please make sure all services have this capability been set correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532501230
Of course. I will patch that alongside my Supabase CI fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1533985868
This issue will be converted as a tracking issue of not fixed issues at storage-api side:
- [ ] https://github.com/supabase/storage-api/issues/133
- [ ] https://github.com/supabase/storage-api/issues/322
- [ ] https://github.com/supabase/storage-api/issues/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532580818
> What do you think, should we raise an issue there?
Yes, please raise an issue to supbase storage-api and link here. We can add `read_with_range` for supabase when they address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2199: servcices/supabase: Tracking issues of not passed test cases
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2199:
URL: https://github.com/apache/incubator-opendal/issues/2199#issuecomment-1532463707
> Also, I found that many tests require `read_with_range` capabilities, but the Supabase seems do not support the http RANGE header.
Supabase seems handled `range` header already:
https://github.com/supabase/storage-api/blob/1794d04ab0e7259d9058293e257f442015252ec3/src/storage/renderer/asset.ts#L14-L20
```rust
getAsset(request: FastifyRequest, options: RenderOptions) {
return this.backend.getObject(options.bucket, options.key, options.version, {
ifModifiedSince: request.headers['if-modified-since'],
ifNoneMatch: request.headers['if-none-match'],
range: request.headers.range,
})
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] servcices/supabase: Tracking issues of not fixed issues at storage-api side [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #2199: servcices/supabase: Tracking issues of not fixed issues at storage-api side
URL: https://github.com/apache/opendal/issues/2199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org