You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/21 04:36:45 UTC

[GitHub] [iotdb] ericpai commented on a change in pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node

ericpai commented on a change in pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095#discussion_r810772068



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/template/TemplateManager.java
##########
@@ -175,9 +176,10 @@ public void checkTemplateCompatible(Template template, IMNode node) throws Metad
       for (IMNode dNode : template.getDirectNodes()) {
         if (dNode.isMeasurement()) {
           throw new MetadataException(
-              "Template and mounted node has different alignment: "

Review comment:
       Hey, this PR causes the unit test  `TemplateTest.testTemplateAlignment` failed. Could you do a patch to fix the test as well?
   
   ![image](https://user-images.githubusercontent.com/3821212/154889863-0c20d2e5-421f-4d4c-9a41-bbdf99b4578f.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org