You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/05/06 09:51:12 UTC

[GitHub] [maven-shared-utils] slawekjaranowski opened a new pull request, #140: [MSHARED-1072] Poll data from input stream

slawekjaranowski opened a new pull request, #140:
URL: https://github.com/apache/maven-shared-utils/pull/140

   Input stream can be a System.in - all read will be blocked 
   We need read data in no blocking mode


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-shared-utils] michael-o commented on pull request #140: [MSHARED-1072] Poll data from input stream

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #140:
URL: https://github.com/apache/maven-shared-utils/pull/140#issuecomment-1537206795

   Does this always apply? Are there cases were in the stream is not `stdin`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-shared-utils] slawekjaranowski merged pull request #140: [MSHARED-1072] Poll data from input stream

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #140:
URL: https://github.com/apache/maven-shared-utils/pull/140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-shared-utils] slawekjaranowski commented on pull request #140: [MSHARED-1072] Poll data from input stream

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #140:
URL: https://github.com/apache/maven-shared-utils/pull/140#issuecomment-1537512937

   > Does this always apply? Are there cases were in the stream is not `stdin`?
   
   It will be safer to use non blocking io in such case.
   Even when stream will be not System.in it will work.
   
   We also can not close provided stream because can be used for multiple executing of invoker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org