You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by di...@apache.org on 2007/08/02 22:59:19 UTC
svn commit: r562253 - in
/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2:
client/ deployment/ description/ engine/ receivers/ transport/http/
transport/mail/server/ transport/tcp/
Author: dims
Date: Thu Aug 2 13:59:17 2007
New Revision: 562253
URL: http://svn.apache.org/viewvc?view=rev&rev=562253
Log:
Fix bad log.error's to make sure they print the stack trace (see http://marc.info/?l=axis-dev&m=118607674929335&w=2)
Modified:
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/AxisConfigBuilder.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisOperation.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisService.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/AxisEngine.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/ListenerManager.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/receivers/AbstractMessageReceiver.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AxisServlet.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/SimpleHTTPServer.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailServer.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailSorter.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Server.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Worker.java
webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/tcp/TCPWorker.java
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/client/ServiceClient.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/client/ServiceClient.java Thu Aug 2 13:59:17 2007
@@ -362,7 +362,7 @@
try {
axisService.disengageModule(module);
} catch (AxisFault axisFault) {
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/AxisConfigBuilder.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/AxisConfigBuilder.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/AxisConfigBuilder.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/AxisConfigBuilder.java Thu Aug 2 13:59:17 2007
@@ -272,7 +272,7 @@
Class deployerClass = Loader.loadClass(deployerClassName);
deployer = (Deployer) deployerClass.newInstance();
} catch (Exception e) {
- log.error(e);
+ log.error(e.getMessage(), e);
return;
}
deployer.setDirectory(directory);
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java Thu Aug 2 13:59:17 2007
@@ -190,9 +190,9 @@
}
}
} catch (MalformedURLException e) {
- log.error(e.getMessage());
+ log.error(e.getMessage(), e);
} catch (IOException e) {
- log.error(e.getMessage());
+ log.error(e.getMessage(), e);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java Thu Aug 2 13:59:17 2007
@@ -303,11 +303,11 @@
operation.setMessageReceiver(inOutmessageReceiver);
}
} catch (ClassNotFoundException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
} catch (InstantiationException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
} catch (IllegalAccessException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java Thu Aug 2 13:59:17 2007
@@ -154,7 +154,7 @@
try {
axisConfig.addParameter(param);
} catch (AxisFault axisFault) {
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
// when the module is an unpacked war file,
@@ -234,7 +234,7 @@
}
} catch (Exception ex) {
- log.error(ex + ": loading repository from classpath");
+ log.error(ex + ": loading repository from classpath", ex);
loadFromClassPath();
}
axisConfig.setConfigurator(this);
@@ -337,7 +337,7 @@
try {
configContext.getAxisConfiguration().addParameter(servletConfigParam);
} catch (AxisFault axisFault) {
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisOperation.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisOperation.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisOperation.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisOperation.java Thu Aug 2 13:59:17 2007
@@ -192,7 +192,7 @@
disengageModule(module);
} catch (AxisFault axisFault) {
// Can't do much here...
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisService.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisService.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisService.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/AxisService.java Thu Aug 2 13:59:17 2007
@@ -1593,16 +1593,16 @@
Definition wsdlDefinition = reader.readWSDL(getBaseURI(wsdlURL.toString()), doc);
return createClientSideAxisService(wsdlDefinition, wsdlServiceName, portName, options);
} catch (IOException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
} catch (ParserConfigurationException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
} catch (SAXException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
} catch (WSDLException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java Thu Aug 2 13:59:17 2007
@@ -284,10 +284,10 @@
return axisService;
} catch (WSDLException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
} catch (Exception e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/AxisEngine.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/AxisEngine.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/AxisEngine.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/AxisEngine.java Thu Aug 2 13:59:17 2007
@@ -173,7 +173,7 @@
// Figure out where this goes
sendFault(faultMC);
} catch (AxisFault axisFault) {
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/ListenerManager.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/ListenerManager.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/ListenerManager.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/engine/ListenerManager.java Thu Aug 2 13:59:17 2007
@@ -243,7 +243,7 @@
listenerManager.stop();
}
} catch (AxisFault axisFault) {
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/receivers/AbstractMessageReceiver.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/receivers/AbstractMessageReceiver.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/receivers/AbstractMessageReceiver.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/receivers/AbstractMessageReceiver.java Thu Aug 2 13:59:17 2007
@@ -247,7 +247,7 @@
} catch (AxisFault e) {
// If we're IN-ONLY, swallow this. Otherwise, send it.
if (messageCtx.getAxisOperation() instanceof InOnlyAxisOperation) {
- log.debug(e);
+ log.debug(e.getMessage(), e);
} else {
try {
MessageContext faultContext =
@@ -255,9 +255,9 @@
AxisEngine.sendFault(faultContext);
} catch (AxisFault axisFault) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java Thu Aug 2 13:59:17 2007
@@ -93,9 +93,9 @@
}
}
} catch (Exception e) {
- log.info(e);
+ log.info(e.getMessage(), e);
} catch (Throwable e) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AxisServlet.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AxisServlet.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AxisServlet.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/AxisServlet.java Thu Aug 2 13:59:17 2007
@@ -156,7 +156,7 @@
throw new ServletException(e);
}
} catch (Throwable t) {
- log.error(t);
+ log.error(t.getMessage(), t);
try {
// If the fault is not going along the back channel we should be 202ing
if (AddressingHelper.isFaultRedirected(msgContext)) {
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java Thu Aug 2 13:59:17 2007
@@ -294,7 +294,7 @@
messageFormatter.writeTo(msgContext, format, out, false);
}
} catch (AxisFault axisFault) {
- log.error(axisFault);
+ log.error(axisFault.getMessage(), axisFault);
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/SimpleHTTPServer.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/SimpleHTTPServer.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/SimpleHTTPServer.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/http/SimpleHTTPServer.java Thu Aug 2 13:59:17 2007
@@ -218,7 +218,7 @@
embedded.init();
embedded.start();
} catch (IOException e) {
- log.error(e);
+ log.error(e.getMessage(), e);
throw AxisFault.makeFault(e);
}
}
@@ -234,7 +234,7 @@
try {
embedded.destroy();
} catch (Exception e) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailServer.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailServer.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailServer.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailServer.java Thu Aug 2 13:59:17 2007
@@ -45,7 +45,7 @@
log.info("Sleeping for a bit to let the mail server start up.");
Thread.sleep(2000);
} catch (InterruptedException e1) {
- log.error(e1);
+ log.error(e1.getMessage(), e1);
}
}
@@ -73,14 +73,14 @@
configurationContext =
ConfigurationContextFactory.createConfigurationContextFromFileSystem(dir, null);
} catch (Exception e) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
try {
log.info("Sleeping for a bit to let the engine start up.");
Thread.sleep(2000);
} catch (InterruptedException e1) {
- log.error(e1);
+ log.error(e1.getMessage(), e1);
}
st = new Storage();
@@ -94,7 +94,7 @@
log.info("Sleeping for a bit to let the engine start up.");
Thread.sleep(2000);
} catch (InterruptedException e1) {
- log.error(e1);
+ log.error(e1.getMessage(), e1);
}
}
@@ -128,7 +128,7 @@
log.info("Giving some time for the sockets to close.");
Thread.sleep(2000);
} catch (InterruptedException e1) {
- log.error(e1);
+ log.error(e1.getMessage(), e1);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailSorter.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailSorter.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailSorter.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/MailSorter.java Thu Aug 2 13:59:17 2007
@@ -142,7 +142,7 @@
engine.sendFault(faultContext);
}
} catch (Exception e1) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Server.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Server.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Server.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Server.java Thu Aug 2 13:59:17 2007
@@ -53,7 +53,7 @@
thread.start();
} catch (Exception e) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Worker.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Worker.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Worker.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/mail/server/POP3Worker.java Thu Aug 2 13:59:17 2007
@@ -173,7 +173,7 @@
socket.close();
} catch (Exception e) {
- log.error(e);
+ log.error(e.getMessage(), e);
}
}
}
Modified: webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/tcp/TCPWorker.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/tcp/TCPWorker.java?view=diff&rev=562253&r1=562252&r2=562253
==============================================================================
--- webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/tcp/TCPWorker.java (original)
+++ webservices/axis2/branches/java/1_3/modules/kernel/src/org/apache/axis2/transport/tcp/TCPWorker.java Thu Aug 2 13:59:17 2007
@@ -91,6 +91,7 @@
Constants.TRANSPORT_TCP));
}
} catch (Throwable e) {
+ log.error(e.getMessage(), e);
try {
AxisEngine engine = new AxisEngine(configurationContext);
@@ -103,7 +104,7 @@
engine.sendFault(faultContext);
}
} catch (Exception e1) {
- log.error(e);
+ log.error(e1.getMessage(), e1);
}
} finally {
if (socket != null) {
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org