You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by sammcveety <gi...@git.apache.org> on 2016/12/03 21:22:37 UTC

[GitHub] incubator-beam pull request #1503: [BEAM-551] Add DisplayData handling of Va...

GitHub user sammcveety opened a pull request:

    https://github.com/apache/incubator-beam/pull/1503

    [BEAM-551] Add DisplayData handling of ValueProvider<String>

    R: @dhalperi 
    
    Notes:
    - An alternative would be to accept ValueProvider<T> and call T.toString() if isAccessible
    - The parameter is not marked @Nullable because the DisplayData code calls checkNotNull


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam sgmc/vp_displaydata

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1503
    
----
commit 9d4efdec6932e2f0f840d84734cc7dc89f614581
Author: Sam McVeety <sg...@google.com>
Date:   2016-12-03T21:20:24Z

    [BEAM-551] Add DisplayData handling of ValueProvider<String>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1503: [BEAM-551] Add DisplayData handling of Va...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---