[jira] [Commented] (NLPCRAFT-29) Refactor prepare.sh/pom.xml to have both "asf" and "binary" releaes.

["Sergey Kamov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NLPCRAFT-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070870#comment-17070870 ] 

Sergey Kamov commented on NLPCRAFT-29:
--------------------------------------

Please check

1) Now 2 signed zips created

See zips folder content:
zips/apache-nlpcraft-bin-0.5.zip
zips/apache-nlpcraft-bin-0.5.zip.md5
zips/apache-nlpcraft-bin-0.5.zip.sha1
zips/apache-nlpcraft-bin-0.5.zip.sha256
zips/apache-nlpcraft-bin-0.5.zip.sig
zips/apache-nlpcraft-src-0.5.zip
zips/apache-nlpcraft-src-0.5.zip.md5
zips/apache-nlpcraft-src-0.5.zip.sha1
zips/apache-nlpcraft-src-0.5.zip.sha256
zips/apache-nlpcraft-src-0.5.zip.sig


2) zips/apache-nlpcraft-bin-0.5.zip - as before
Content:
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/bin/
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/build/
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/javadoc/
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/openapi/
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/sql/
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/src/
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/LICENSE
zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/NOTICE

3) zips/apache-nlpcraft-src-0.5.zip
Deleted: build, javadoc folders
Added: pom.xml, assembly.xml, README.md files
Content:
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/openapi/
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/sql/
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/src/
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/NOTICE
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/README.md
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/assembly.xml
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/LICENSE
zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/pom.xml


4) >> remove '*.iml' files from the release -

Do you have these files in prepared zip? 
I don't and can't find how it can be added to zip.

> Refactor prepare.sh/pom.xml to have both "asf" and "binary" releaes.
> --------------------------------------------------------------------
>
>                 Key: NLPCRAFT-29
>                 URL: https://issues.apache.org/jira/browse/NLPCRAFT-29
>             Project: NLPCraft
>          Issue Type: Task
>          Components: build
>            Reporter: Aaron Radzinski
>            Assignee: Sergey Kamov
>            Priority: Major
>             Fix For: 0.5.0
>
>
> prepare.sh script should be refactored to create two "zip" folders:
>  * 'src' for standard ASF release (source code only release)
>  * 'bin' for additional non-ASF binary release (source code + built all-deps JAR)
> Current prepare.sh script builds 'bin' release. The following needs to change:
>  * remove '*.iml' files from the release
> Source 'src' release ZIP should contain:
>  * pom.xml + all necessary files to build JARs
>  * NO built JAR files
>  * README files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)