[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5359: when i use @Aspect Annotation in a spring cloud app it has some infos

[GitBox <gi...@apache.org>]

kezhenxu94 edited a comment on issue #5359:
URL: https://github.com/apache/skywalking/issues/5359#issuecomment-711103098


   This doesn’t effect the application’s logic, it just says the added internal methods cannot be instrumented, but the original one is still there to take effect. According to the codes, I think you only want to print the arguments of the controller, nothing to do with the internal methods added by SkyWalking, right?
   
   
   I think you should rewrite your pointcut to only intercept methods that are `public` or annotated with `@RequestMapping`(or `@GetMapping` and other similar for POST, ect.), intercepting all methods in a controller is not realistic in a real scenario(it’s very likely that we have private methods in a controller) and I consider it as a bad practice(it costs too much extra and unnecessarily)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org