You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/10 18:32:00 UTC
[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset
when created from UI
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645389#comment-16645389 ]
ASF GitHub Bot commented on GRIFFIN-206:
----------------------------------------
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/435
[GRIFFIN-206] fix job timezone when creating from UI
Demonstration:
```
> new Date()
Wed Oct 10 2018 11:30:48 GMT-0700 (Pacific Daylight Time)
> new Date().getTimezoneOffset()/60
7
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chemikadze/incubator-griffin GRIFFIN-206
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/435.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #435
----
commit 03059a27a1f7fa11118a7f839681f716fe1e66e0
Author: Nikolay Sokolov <ch...@...>
Date: 2018-10-10T18:28:51Z
[GRIFFIN-206] fix job timezone when creating from UI
----
> Wrong sign of time zone offset when created from UI
> ---------------------------------------------------
>
> Key: GRIFFIN-206
> URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> Project: Griffin (Incubating)
> Issue Type: Bug
> Reporter: Nikolay Sokolov
> Assignee: Nikolay Sokolov
> Priority: Major
>
> When job is created from UI, time zone offset is created by this piece of code:
> {code:none}
> let time = new Date().getTimezoneOffset() / 60;
> let timezone = "GMT" + time + ":00";
> {code}
> Problem is, that for GMT-7 it yields positive number, resulting in calculated timezone to be GMT+7.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)