You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/10/12 11:13:26 UTC
[GitHub] [orc] pgaref opened a new pull request #550: ORC:673: PPD: LTE Point equality comparison is wrong when RG MIN==MAX
pgaref opened a new pull request #550:
URL: https://github.com/apache/orc/pull/550
Change-Id: I0c8d5838c153b4837048c183e4bab361af9b6767
### What changes were proposed in this pull request?
FIx PPD Less than Equals comparison for min==max corner case
### Why are the changes needed?
Better PPD evaluation
### How was this patch tested?
Extra JUnit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #550:
URL: https://github.com/apache/orc/pull/550#issuecomment-709028293
Hey @dongjoon-hyun -- you are right, will make sure the affected versions are properly set next time :)
Also 1.5 needed a bit of tweaking so I just opened #551 and #552 for the backports
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref closed pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
pgaref closed pull request #550:
URL: https://github.com/apache/orc/pull/550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #550:
URL: https://github.com/apache/orc/pull/550#issuecomment-708871673
Please make a backporting PR, @pgaref .
BTW, it would be great if you adds the required versions into `Affected Versions` next time.
I didn't backport this PR because the affected version field is empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #550:
URL: https://github.com/apache/orc/pull/550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #550:
URL: https://github.com/apache/orc/pull/550#issuecomment-707625659
Hey @dongjoon-hyun thanks for the fast review!
Since this patch is fixing PPD behaviour for LTE comparisons I believe we should also backport to 1.5 and 1.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #550:
URL: https://github.com/apache/orc/pull/550#issuecomment-708871673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #550: ORC-673: PPD LTE Point equality comparison is wrong when RG MIN==MAX
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #550:
URL: https://github.com/apache/orc/pull/550#issuecomment-707057321
Hey @omalley @dongjoon-hyun @jcamachor can you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org