You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/10 21:55:04 UTC
[jira] [Commented] (KAFKA-5214) KafkaAdminClient#apiVersions should
return a public class
[ https://issues.apache.org/jira/browse/KAFKA-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005523#comment-16005523 ]
ASF GitHub Bot commented on KAFKA-5214:
---------------------------------------
GitHub user cmccabe opened a pull request:
https://github.com/apache/kafka/pull/3012
KAFKA-5214: KafkaAdminClient#apiVersions should return a public class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmccabe/kafka KAFKA-5214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3012
----
commit 5e2dc72bf74a98f5bfca4b863ddfd26366481f26
Author: Colin P. Mccabe <cm...@confluent.io>
Date: 2017-05-10T21:53:42Z
KAFKA-5214: KafkaAdminClient#apiVersions should return a public class
----
> KafkaAdminClient#apiVersions should return a public class
> ---------------------------------------------------------
>
> Key: KAFKA-5214
> URL: https://issues.apache.org/jira/browse/KAFKA-5214
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
>
> KafkaAdminClient#apiVersions should not refer to internal classes like ApiKeys, NodeApiVersions, etc. Instead, we should have stable public classes to represent these things in the API.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)