You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2012/10/02 14:47:08 UTC

[jira] [Resolved] (OAK-241) QueryEngine.executeQuery needs a session parameter

     [ https://issues.apache.org/jira/browse/OAK-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu resolved OAK-241.
---------------------------------

    Resolution: Invalid

Marking this issue as invalid - with OAK-355 we've decided to remove the session reference.
                
> QueryEngine.executeQuery needs a session parameter
> --------------------------------------------------
>
>                 Key: OAK-241
>                 URL: https://issues.apache.org/jira/browse/OAK-241
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>
> The method QueryEngine.executeQuery currently needs a ContentSession parameter, even thought the instance was retrieved from the ContentSession using ContentSession.getQueryEngine(). This is a bit confusing.
> To solve this, we could rename the QueryEngine interface to SessionQueryEngine, change QueryEngineImpl so it no longer implements any interface, add a class SessionQueryEngineImpl that calls the QueryEngineImpl methods (1:1, except for executeQuery where it adds the session parameter).
> An alternative would be to change the existing QueryEngineImpl so a new instance is created for each session. But I prefer not todo this as conceptually there is only one query engine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira