[jira] Commented: (HADOOP-6432) Statistics support in FileContext

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791534#action_12791534 ] 

Suresh Srinivas commented on HADOOP-6432:
-----------------------------------------

# Can you please add a brief description of what the patch does
# FileContext.java - remove Options.Rename import
# All FileContext.java public methods added should have javadoc
# FileContext.getStatistics() - add more description to the method that only scheme and authority is used for looking up the file system.
# FileContext.getAllStatistics() - should not throw URISyntaxException.
# AbstractFileSystem.java - IdentifyHashMap import is unused
# AbstractFileSystem.STATISTICS_TABLE declaration exceeds 80 columns.
# AbstractFileSystem.getStatistics() - use getUri() method get the URI with scheme and authority.
# AbstractFileSystem and FileContext printStatistics() prints the statistics using System.out.println. Not sure where this is used and if we need it.
# AbstractFileSystem.getAllStatistics - initialize statsMap size to that of STATISTICS_TABLE. Also it is a good idea to define copy constructor in Statistics class.
# Is it a good idea to have FcStatisticsTest that includes common logic and have a subclass for TestLocalFcStatistics, TestHdfsFcStatistics etc? Could the base test use FileContextTestHelper and avoid using /tmp as directory to create tests. Also code could be reused by adding a method checkStatistics(int expectedBytesRead, int expectedBytesWritten, Statistics s)


> Statistics support in FileContext
> ---------------------------------
>
>                 Key: HADOOP-6432
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6432
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>         Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch
>
>
> FileContext should have API to get statistics from underlying file systems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.